Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEAT Auth Context #77

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

FEAT Auth Context #77

wants to merge 1 commit into from

Conversation

toopay
Copy link
Member

@toopay toopay commented Oct 7, 2024

Description

For any authenticated request, set the authentication context to be used by the controller (especially REST controllers) to identify the corresponding authenticated user.

Also, de-escalate pkg db error from Fatal to Panic.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)
  • Unit Tests

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@toopay toopay changed the title FEAT de-escalate pkg db error from Fatal to Panic FEAT Auth Context Oct 7, 2024
Copy link

codecov bot commented Oct 7, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
pkg/db/relation.go 0.00% 3 Missing ⚠️
pkg/db/select.go 0.00% 1 Missing ⚠️
Flag Coverage Δ
-race 72.16% <0.00%> (-0.07%) ⬇️
-tags "sonic avx" 72.21% <0.00%> (ø)
-tags go_json 72.21% <0.00%> (-0.02%) ⬇️
-tags nomsgpack 72.24% <0.00%> (+0.09%) ⬆️
go-1.21 71.56% <0.00%> (ø)
go-1.22 72.21% <0.00%> (+0.01%) ⬆️
macos-latest 72.24% <0.00%> (ø)
ubuntu-latest 72.23% <0.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
pkg/db/select.go 88.88% <0.00%> (ø)
pkg/db/relation.go 71.81% <0.00%> (ø)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant