Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MwCAS implementation tracking #12

Open
XiangpengHao opened this issue Jan 22, 2020 · 0 comments
Open

MwCAS implementation tracking #12

XiangpengHao opened this issue Jan 22, 2020 · 0 comments

Comments

@XiangpengHao
Copy link
Member

XiangpengHao commented Jan 22, 2020

This issue tracks the modifications to current MwCAS implementation.

The continuous benchmark can be found here: https://dev.azure.com/haoxiangpeng/pmwcas/_dashboards/dashboard/7ed85ecc-8da6-4958-977e-efb77c25afcc

  • Address flushes are added back because they are believed to be necessary, this result in performance drop about:
    image

  • https://github.com/XiangpengHao/pmwcas/blob/dev/src/mwcas/mwcas.cc#L708 is deleted, resulting in performance increase by:
    image

  • After a second thought, the address flush after the description installation should not be necessary. So remove it and we get back to the old performance:
    image

  • Now we use RTM by default and use the normal CAS based descriptor installation as the fallback plan.

  • We now make a copy of the data before persisting it, by doing this we can avoid some cache misses.

@XiangpengHao XiangpengHao pinned this issue Jan 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant