Refactor _readAggregateValueFromInitializerList by reusing existing ResolveInvoke logic #5134
Labels
goal:forward looking
Feature needed at a later date, not connected to a specific use case.
Milestone
Backgroud:
This sub-task is split from #3406.
I wrap up Arial's PR #4854 to a new PR #5107 with some minor issues solved.
However, there still be lots of comments could potential involve large change on this PR.
We should not make one PR has infinitely long conversion and unlimited problems solved, so this task is create to only spot this issue.
Here is the comment:
#5107 (comment)
TLDR: we have to refactor the code in _readAggregateValueFromInitializerList to reuse the logic of ResolveInvoke.
The only challenge in this task is that we have to run all the current tests and to see which use cases the change could break and fix them. Because there is no clear design doc for the original implementation, we're not quite understand what issues or use-cases that each piece of logic is trying to resolve. So to refactor or remove some logic, we need to experiment on the tests to find out how those logic could break things.
The text was updated successfully, but these errors were encountered: