Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wgsl: Fix field semantics even if input struct doesn't need flattening #5642

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

wgsl: Fix field semantics even if input struct doesn't need flattening #5642

wants to merge 2 commits into from
+96 −3

Conversation

aleino-nv
Copy link
Collaborator

This fixes an issue where location indices of stage inputs were repeated

#5633

@aleino-nv aleino-nv requested a review from a team as a code owner November 22, 2024 11:48
@aleino-nv aleino-nv added the pr: non-breaking PRs without breaking changes label Nov 22, 2024
@aleino-nv aleino-nv mentioned this pull request Nov 22, 2024
Open
@aleino-nv
Copy link
Collaborator Author

Falcor tests failed:

  internal/renderpasses/test_InternalPathTracer_vulkan         : FAILED (600.0 s)
    Process killed due to timeout
    View test at: http://SlangWin5:8080//unknown/internal/renderpasses/test_InternalPathTracer_vulkan

jkwak-work
jkwak-work requested changes Nov 22, 2024
View reviewed changes
Copy link
Collaborator

@jkwak-work jkwak-work left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel uncomfortable with this change.

The code is copied exactly from slang-ir-metal-legalize.cpp
And with this PR, WGPU side works but Metal side is failing.

I suggest to investigate why Metal is failing and fix it properly before merging this change.

@csyonghe
Copy link
Collaborator

I feel like metal needs the same treatment.

@jkwak-work
Copy link
Collaborator

I feel like metal needs the same treatment.

Yes, that must be it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkwak-work jkwak-work jkwak-work approved these changes

@csyonghe csyonghe csyonghe approved these changes

Assignees
No one assigned
Labels
pr: non-breaking PRs without breaking changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aleino-nv @csyonghe @jkwak-work