Skip to content
This repository has been archived by the owner on Aug 21, 2024. It is now read-only.

Widevine plugin doesn't copy binaries #211

Open
andrej-repisky opened this issue Mar 17, 2021 · 2 comments
Open

Widevine plugin doesn't copy binaries #211

andrej-repisky opened this issue Mar 17, 2021 · 2 comments
Labels
type: enhancement New feature or request
Milestone

Comments

@andrej-repisky
Copy link

andrej-repisky commented Mar 17, 2021

The Shaka player embedded plugin in Widevine CMD repo doesn't work as described in this readme paragraph:

## Shaka Player Embedded Plugin

This repository also provides a plugin that can be used to automatically add
Widevine support to [Shaka Player Embedded][].  All you need to do is use the
`dev_cdm.json` or `release_cdm.json` files and pass them to the `./configure`
script of Shaka Player Embedded.  For example:

./configure --ios --eme-impl ~/prebuilt_cdm/shaka_plugin/dev_cdm.json

The certificate will be handled automatically and the resulting Shaka Player
Embedded framework bundle will contain the embedded Widevine CDM.  This means
the resulting Shaka Player Embedded framework is usable by itself.

The resulting shaka player build directory doesn't contain Widevine CDM anywhere.

Build Environment

Shaka player emb., commit dabbeb5
Widevine CDM 5.2.4
Xcode 12.4

@TheModMaker
Copy link
Contributor

I didn't update the docs there when I fixed #63. You need to manually add the CDM to your app's frameworks in addition to Shaka embedded's two frameworks.

@TheModMaker TheModMaker added type: bug Something isn't working correctly type: docs Improvements or fixes to documentation labels Mar 17, 2021
@TheModMaker TheModMaker added this to the v1.1 milestone Mar 17, 2021
@TheModMaker
Copy link
Contributor

I've updated the CDM docs. One thing we should do is to copy the correct CDM to the build directory. That would at least make it easier for people to find the correct one. For now you need to find the correct version in the lib folder of the CDM repo.

@TheModMaker TheModMaker added type: enhancement New feature or request and removed type: bug Something isn't working correctly type: docs Improvements or fixes to documentation labels Mar 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants