From c7d2aef57843b53db1ea43bda7654f22414f6ad6 Mon Sep 17 00:00:00 2001 From: local Date: Mon, 12 Dec 2022 10:42:41 -0800 Subject: [PATCH] REGRESSION (256665@main): [ Ventura ] fast/images/avif-as-image.html is a consistent image failure https://bugs.webkit.org/show_bug.cgi?id=248544 rdar://102823196 Reviewed by Simon Fraser. libavif does not render fast/images/resources/green-313x313.avif and fast/images/resources/green-400x400.avif correctly. See https://github.com/AOMediaCodec/av1-avif/issues/195. We need to fix the expectation file fast/images/avif-as-image-expected.html with the correct rendering; i.e. the image should be lime not green. This will require marking this test [ ImageOnlyFailure ] for non Apple ports and macOS down-level ports. * LayoutTests/TestExpectations: * LayoutTests/fast/images/avif-as-image-expected.html: * LayoutTests/platform/ios/TestExpectations: * LayoutTests/platform/mac-ventura/TestExpectations: * LayoutTests/platform/mac/TestExpectations: Canonical link: https://commits.webkit.org/257738@main --- LayoutTests/TestExpectations | 3 ++- LayoutTests/fast/images/avif-as-image-expected.html | 2 +- LayoutTests/platform/ios/TestExpectations | 1 - LayoutTests/platform/mac-ventura/TestExpectations | 2 -- LayoutTests/platform/mac/TestExpectations | 2 +- 5 files changed, 4 insertions(+), 6 deletions(-) diff --git a/LayoutTests/TestExpectations b/LayoutTests/TestExpectations index 389516144d7fa..de778e80bfc42 100644 --- a/LayoutTests/TestExpectations +++ b/LayoutTests/TestExpectations @@ -2252,8 +2252,9 @@ fast/images/animated-webp.html [ Skip ] # These tests don't have to be platform-specific, but they are only implemented on Mac now. fast/images/eps-as-image.html [ Skip ] -# libavif does not render resources/green-400x400.avif correctly. +# libavif does not render resources/green-313x313.avif and resources/green-400x400.avif correctly. # See https://github.com/AOMediaCodec/av1-avif/issues/195 +fast/images/avif-as-image.html [ ImageOnlyFailure ] fast/images/avif-heif-container-as-image.html [ ImageOnlyFailure ] # Only applicable on platforms with JPEG XL support diff --git a/LayoutTests/fast/images/avif-as-image-expected.html b/LayoutTests/fast/images/avif-as-image-expected.html index b7f15c00b5253..8237d43b58d29 100644 --- a/LayoutTests/fast/images/avif-as-image-expected.html +++ b/LayoutTests/fast/images/avif-as-image-expected.html @@ -3,7 +3,7 @@ div { width: 313px; height: 313px; - background-color: green; + background-color: lime; } diff --git a/LayoutTests/platform/ios/TestExpectations b/LayoutTests/platform/ios/TestExpectations index 68922677809d4..868689074e900 100644 --- a/LayoutTests/platform/ios/TestExpectations +++ b/LayoutTests/platform/ios/TestExpectations @@ -3787,7 +3787,6 @@ imported/w3c/web-platform-tests/css/selectors/selection-image-002.html [ ImageOn # AVIF tests webkit.org/b/247831 fast/images/avif-image-decoding.html [ Failure ] -webkit.org/b/247831 fast/images/avif-as-image.html [ ImageOnlyFailure ] webkit.org/b/247831 fast/images/animated-avif.html [ Timeout ] # Screen Orientation API doesn't support nested frames yet diff --git a/LayoutTests/platform/mac-ventura/TestExpectations b/LayoutTests/platform/mac-ventura/TestExpectations index e283093925320..09545ac883d64 100644 --- a/LayoutTests/platform/mac-ventura/TestExpectations +++ b/LayoutTests/platform/mac-ventura/TestExpectations @@ -1,3 +1 @@ webkit.org/b/245686 [ Ventura+ ] fast/text/system-font-fallback.html [ ImageOnlyFailure ] - -webkit.org/b/248544 [ Ventura+ ] fast/images/avif-as-image.html [ ImageOnlyFailure ] diff --git a/LayoutTests/platform/mac/TestExpectations b/LayoutTests/platform/mac/TestExpectations index f69ea705af157..468933a792e58 100644 --- a/LayoutTests/platform/mac/TestExpectations +++ b/LayoutTests/platform/mac/TestExpectations @@ -108,6 +108,7 @@ fast/images/heic-as-background-image.html [ Pass ] fast/images/mac/play-all-pause-all-animations-context-menu-items.html [ Skip ] # AVIF tests +[ Ventura+ ] fast/images/avif-as-image.html [ Pass ] [ Ventura+ ] fast/images/avif-heif-container-as-image.html [ Pass ] # fast/events/mouseout-on-window.html needs mac DRT to issue mouse out events @@ -2400,7 +2401,6 @@ svg/transforms/translation-tiny-element.svg [ ImageOnlyFailure ] [ Ventura+ x86_64 ] http/tests/media/now-playing-info.html [ Pass Failure ] [ BigSur+ x86_64 ] animations/stop-animation-on-suspend.html [ Pass Failure ] [ Ventura+ ] imported/w3c/web-platform-tests/mathml/relations/css-styling/display-2.html [ Failure ] -[ Ventura+ ] fast/images/avif-as-image.html [ ImageOnlyFailure Crash ] [ BigSur+ ] fast/images/animated-avif.html [ Pass ImageOnlyFailure Timeout Crash ] [ Ventura+ ] animations/animation-events-not-cancelable.html [ Pass Failure ] [ Bigsur+ ] animations/remove-syncing-animation.html [ Pass Failure ]