Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for submodules under static/ #89

Open
samueloph opened this issue Oct 24, 2024 · 1 comment
Open

Support for submodules under static/ #89

samueloph opened this issue Oct 24, 2024 · 1 comment

Comments

@samueloph
Copy link

I have tried adding a submodule under static/ at samueloph/samueloph.github.io@517a722

When I tried to use that, for example, with [samuel_henrique_samueloph_cv_2024_03.pdf](../personal_website_files/samuel_henrique_samueloph_cv_2024_03.pdf), I got a 404 on gh-pages, even though it works with zola serve locally.

Looking at the gh-pages branch: https://github.com/samueloph/samueloph.github.io/tree/df08af396275b663eae79869635b8d37b56bd737/

The submodule personal_website_files seem wrong.

The CI job also failed at https://github.com/samueloph/samueloph.github.io/actions/runs/11497188825/job/32000372269, with:

Fetching submodules
  /usr/bin/git submodule sync --recursive
  /usr/bin/git -c protocol.version=2 submodule update --init --force --depth=1 --recursive
  Error: fatal: No url found for submodule path 'personal_website_files' in .gitmodules
  Error: The process '/usr/bin/git' failed with exit code 128

It looks like zola-deploy-action doesn't support submodules under the static/ folder, is that right?

@samueloph
Copy link
Author

I've managed to workaround the issue by forking the repo and doing this change:
samueloph@54dd5b0

This is specific to the submodule I'm using, but it's very easy to change it to fit another usecase.

Unfortunately the solution is not good enough to be merged in the main repo, as it hardcodes the submodule.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant