Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add experimental CoAP server implementation #134

Draft
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

JKRhb
Copy link
Contributor

@JKRhb JKRhb commented Oct 15, 2022

I started working on a simple, experimental server implementation (which currently only supports UDP). For now, this is only a proof-of-concept, which can be improved upon once #127 has been merged.

@JosefWN
Copy link
Contributor

JosefWN commented Oct 16, 2022

Cool!

Speaking of which, it would be really cool with integration tests against a server in the build pipeline/GitHub Actions. Re-writing our examples as integration tests and running them on push to a branch with an open PR... I was a bit hesitant to do this with coap.me or Californium since they are external and any issues with them would cause our pipelines to fail. Also having a third-party server like Coap.NET in our repo felt wrong.

It could be a lot of work to cover all examples, but even some would be a big win. Another option is to run them against Californium, which seems to be the best maintained, and allow for merging on failure if that's possible (or force merge on temporary issues).

@codecov-commenter
Copy link

codecov-commenter commented Jul 2, 2023

Codecov Report

Patch coverage: 1.16% and project coverage change: -0.47 ⚠️

Comparison is base (c6f2bb1) 29.91% compared to head (e854831) 29.45%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #134      +/-   ##
==========================================
- Coverage   29.91%   29.45%   -0.47%     
==========================================
  Files          62       63       +1     
  Lines        2811     2855      +44     
==========================================
  Hits          841      841              
- Misses       1970     2014      +44     
Impacted Files Coverage Δ
lib/src/coap_client.dart 0.00% <0.00%> (ø)
lib/src/coap_constants.dart 0.00% <0.00%> (ø)
lib/src/coap_message.dart 46.63% <ø> (ø)
lib/src/coap_observe_client_relation.dart 0.00% <0.00%> (ø)
lib/src/coap_request.dart 37.14% <0.00%> (ø)
lib/src/coap_server.dart 0.00% <0.00%> (ø)
lib/src/stack/layers/observe.dart 0.00% <0.00%> (ø)
lib/src/option/uri_converters.dart 67.12% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants