Skip to content
This repository has been archived by the owner on Apr 11, 2023. It is now read-only.

investor-foxy: Wrong releaseTime #921

Open
gomesalexandre opened this issue Jul 29, 2022 · 4 comments
Open

investor-foxy: Wrong releaseTime #921

gomesalexandre opened this issue Jul 29, 2022 · 4 comments
Labels
Milestone

Comments

@gomesalexandre
Copy link
Contributor

Overview

Taking over shapeshift/web#2103

Currently in investor-foxy, getTimeUntilClaimable sometimes returns a wrong releaseTime:

releaseTime = await this.getTimeUntilClaimable(input)

The high-level reason for that is investor-foxy mimics the FOXy contract methods / state and has potential for a wrong reconciliation.

We should fix it so that getTimeUntilClaimable returns us the correct release time, making sure we don't disable the claim button when claims are actually available.

References and additional details

shapeshift/web#2103

releaseTime = await this.getTimeUntilClaimable(input)

Acceptance Criteria

  • The right releaseTime is return by getTimeUntilClaimable
  • getWithdrawInfo doesn't throw if user is available to claim

Need By Date

No response

Screenshots/Mockups

No response

Estimated effort

No response

@gomesalexandre
Copy link
Contributor Author

@NeOMakinG Assigning you so you can add some context to this

@toshiSat
Copy link
Contributor

toshiSat commented Jul 29, 2022

We need to figure out the timeframe this is happening. I'm suspecting that a current rebase is pending, which would block the user from being able to claim. In V2 I added a rebase before the user claims on the claimWithdraw function. One way we could solve this is adding a rebase to the gelato bot if this is the reason. We really need more information to help debug this. When a user reports this we need their address so we can check the coolDownInfo and see what epoch their claim should be. If the epoch is correct then it is a problem in lib, but if not then adding a call to rebase on the gelato bot will fix this.

@0xdef1cafe
Copy link
Collaborator

@toshiSat you want this as a bounty?

@0xdef1cafe 0xdef1cafe added this to the Miscellaneous milestone Aug 3, 2022
@toshiSat
Copy link
Contributor

toshiSat commented Aug 4, 2022

I am finishing up 3 projects right now and am taking a much needed vacation. If this is still open after my break I can pick it up as a bounty. We will need to look into someones address that this is currently happening. I don't see how this could be wallet related as the description suggests.

@NeOMakinG NeOMakinG removed their assignment Aug 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

4 participants