-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Nushell Files #2129
Comments
The syntax doesn't seem to meet our current criteria for inclusion. Note that there is an easy way to customize your version of bat: https://github.com/sharkdp/bat#adding-new-syntaxes--language-definitions |
That inclusion criteria seems to require publishing a sublime package, which nushell apparently currently does not. If the spirit of your inclusion criteria is about ensuring a certain popularity (for balancing utility vs cost of maintenance), then I'd kindly ask you to reconsider the inclusion of the nushell syntax 🙏. |
I would personally say that the criteria are there for multiple (though perhaps interrelated) reasons:
There's no law that says it has to be an official grammar, many decent language grammars are entirely community maintained. Given that we have already said it would require conversation from a vscode format to an ST compatible one and nobody seems to have attempted it or built one from scratch, I think it is fair to say interest by Sublime users and syntect users is low... So at this stage, I believe your options are to do the work and use it yourself, potentially making a PR here if you've created a git repo for it, or to wait and see if anyone will ever add (vscode flavor) tmLanguage support to syntect... |
For the next person: I'm aware of 2 implementations of
Note that imo 2. provided much better highlighting, perhaps because it is more recently updated at time of writing. |
Awesome thanks for the tip! |
Syntax:
Nushell, a data-driven document language.
The authors of the language provide a syntax definition for VSCode in
tmLanguage.json
: https://github.com/nushell/vscode-nushell-lang/tree/main/syntaxesGuideline Criteria:
None. Maybe, the support should wait for a solution in the
syntect
crate so that it can readtmLanguage
files (see here) and Nushell'stmLanguage.json
can be imported as a Git submodule.The text was updated successfully, but these errors were encountered: