Skip to content

Commit

Permalink
[GLUTEN-7208][VL] Fix loading libvelox.so failed when using static gl…
Browse files Browse the repository at this point in the history
…og (apache#7209)
  • Loading branch information
JinHelin404 authored and shamirchen committed Oct 14, 2024
1 parent ddbe2f7 commit 194a88b
Showing 1 changed file with 5 additions and 7 deletions.
12 changes: 5 additions & 7 deletions cpp/core/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -213,13 +213,11 @@ file(MAKE_DIRECTORY ${root_directory}/releases)
add_library(gluten SHARED ${SPARK_COLUMNAR_PLUGIN_SRCS})
add_dependencies(gluten jni_proto)

if(ENABLE_GLUTEN_VCPKG)
# Hide symbols of some static dependencies. Otherwise, if such dependencies
# are already statically linked to libvelox.so, a runtime error will be
# reported: xxx is being linked both statically and dynamically.
target_link_options(
gluten PRIVATE -Wl,--version-script=${CMAKE_CURRENT_SOURCE_DIR}/symbols.map)
endif()
# Hide symbols of some static dependencies. Otherwise, if such dependencies are
# already statically linked to libvelox.so, a runtime error will be reported:
# xxx is being linked both statically and dynamically.
target_link_options(
gluten PRIVATE -Wl,--version-script=${CMAKE_CURRENT_SOURCE_DIR}/symbols.map)

if(CMAKE_CXX_COMPILER_VERSION VERSION_LESS 9.0)
execute_process(
Expand Down

0 comments on commit 194a88b

Please sign in to comment.