Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

5 failing tests #2

Open
1 of 5 tasks
slyrus opened this issue Apr 6, 2019 · 3 comments
Open
1 of 5 tasks

5 failing tests #2

slyrus opened this issue Apr 6, 2019 · 3 comments

Comments

@slyrus
Copy link
Member

slyrus commented Apr 6, 2019

When one does:

(ql:quickload :cxml-stp-test)

one gets:

4 out of 246 total tests failed: TEXT.SERIALIZE, 
   ELEMENT.ADD-EXTRA-NAMESPACE.4, ELEMENT.COPY.7, ELEMENT.BASE-URI.

Notice I said 5, not 4, as pull request #1 fixes the with-attributes test, which still fails on the master branch.

Fixed:

  • TEXT.SERIALIZE
  • ELEMENT.ADD-EXTRA-NAMESPACE.4
  • ELEMENT.COPY.7
  • ELEMENT.WITH-ATTRIBUTES
  • ELEMENT.BASE-URI
@scymtym
Copy link
Member

scymtym commented Apr 9, 2019

I added a list with checkboxes so we can cross off tests as we fix them.

@slyrus
Copy link
Member Author

slyrus commented Apr 15, 2019

For text.serialize, It looks we don't escape quotes when we serialize-to-string, but given the comment about "zzz CXML traditionally escapes quotes without good reason" maybe the current behavior is correct and we should just check for unescaped quotes.

@slyrus
Copy link
Member Author

slyrus commented Apr 15, 2019

in element.copy.7, the make-element call fails because the results of the format nil call are not a runes:simple-rod but rather some sort of optimized string. We can coerce it to a 'runes:simple-rod and the test will pass, but is that the right thing to do?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants