Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deadcode in the DataReader.py file #5

Open
yahuvi opened this issue Oct 17, 2017 · 0 comments
Open

deadcode in the DataReader.py file #5

yahuvi opened this issue Oct 17, 2017 · 0 comments

Comments

@yahuvi
Copy link

yahuvi commented Oct 17, 2017

I found two bugs:

1.in line 377,"if v=='dontcare' and s=='this':",where s=='this' ,in CamRest676.json it's not found that the slot equal 'this'
issue code location:

if v=='dontcare' and s=='this':

2.in line 380,"if sda['act']=='request':",where sda['act'] ,variable sda has no attribute 'act' ,because in CamRest676.json,items of DA is string type and similar to the following:
"sys": { "sent": "There are several restaurants in the south part of town that serve expensive food. Do you have a cuisine preference?", "DA": [ "food" ] }
issue code location:

if sda['act']=='request':

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant