Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update koboutils dependency to v2.2.0 #52

Merged
merged 7 commits into from
Jul 6, 2024
Merged

Conversation

SmatMan
Copy link
Contributor

@SmatMan SmatMan commented Jun 21, 2024

Refer to #51

@shermp
Copy link
Owner

shermp commented Jun 21, 2024

Hi, thanks to looking into this.

I think we as may as well update to the latest kobutils commit (3392dec). which also supports the new colour devices. Also feel free to update the Go version.

@shermp
Copy link
Owner

shermp commented Jun 21, 2024

Oh, I see, the workflow sets Go 1.17

@SmatMan
Copy link
Contributor Author

SmatMan commented Jun 28, 2024

I didn't upgrade Go as it strangely didn't seem to build with 1.21
I'm updating to the latest koboutils commit at the moment.

@SmatMan
Copy link
Contributor Author

SmatMan commented Jun 28, 2024

Seemed to build fine with the dependency upgrade, I'm going to try to update Go now, but I don't have too much experience with go so I'm trying not to change too much haha

@SmatMan
Copy link
Contributor Author

SmatMan commented Jun 28, 2024

Go update didn't seem to work due to the error discussed in this issue: golang/go#61888
Since I'm not too experienced with go, and since the build seems to work with go 1.17, I'm going to leave it as is. I'll test on my libra colour when I'm able!

@shermp shermp merged commit 03a14c8 into shermp:master Jul 6, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants