Proposal to simplify the terraform module inputs #48
Replies: 3 comments
-
I think this is a good idea, and since we needed to take into account the differences in naming conventions for different Azure resources, we initially decided to leave all names up to the user, but I can understand why this would be redundant. |
Beta Was this translation helpful? Give feedback.
-
Looks like you've implemented this. Thanks! |
Beta Was this translation helpful? Give feedback.
-
@shibayan bringing this in will require us to recreate many resources, most worryingly the Storage Account. As I'm not super familiar with the upstream application, can it survive this loss of data or will I need to backup this data before proceeding? |
Beta Was this translation helpful? Give feedback.
-
I propose removing inputs for resources that are "internal" to the module.
Those configuration items are:
As these are internal to the application, I think a better method would be to simply use a name base variable to compose these resource names.
For examples,
function_name_base = "acmebot-${random_string.random.result}"
And then internally we can compose the other resource names like this:
The storage account resource might be a little tricky but I think it could work.
Beta Was this translation helpful? Give feedback.
All reactions