Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Public.rb should check for response.code and not response.status #20

Open
electricflux opened this issue Dec 26, 2017 · 0 comments
Open

Public.rb should check for response.code and not response.status #20

electricflux opened this issue Dec 26, 2017 · 0 comments

Comments

@electricflux
Copy link

The public client is checking for response.status so that it can raise an error if the status is not 200. It should be checking for response.code instead.

Error: httparty-0.15.6/lib/httparty/response.rb:93:in method_missing': undefined method status' for #<HTTParty::Response:0x0000000120ca00> (NoMethodError)
natonnelier added a commit to natonnelier/kraken_client that referenced this issue Jan 3, 2018
@natonnelier
response.code replacing status in response check
24b96e5 
Checking method changed in order to avoid HTTParty error pointed out here: shideneyu#20
@natonnelier natonnelier mentioned this issue Jan 3, 2018
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@electricflux