Prisma regression with JS engine

[slevithan]

Validations

• Follow our Code of Conduct
• Read the Contributing Guide.
• Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.

Describe the bug

Prisma just regressed with the JS engine (moving from supported to unsupported), and is throwing "Error: Quantifier requires a repeatable token" via the report-engine-js script. Looks like the cause is this recent addition from commit shikijs/textmate-grammars-themes@f500671 (upstream PR: prisma/language-tools#1806).

Looks like the addition to the Prisma grammar is meant to be treated as a literal text search (since */ is not a valid regex pattern). Should the JS engine be handling this block as literal text searches rather than passing it to the regex engine as regex patterns?

Reproduction

pnpm run report-engine-js

Contributes

• I am willing to submit a PR to fix this issue
• I am willing to submit a PR with failing tests

[antfu]

I am curious how Oniguruma handles this. To me this looks like a mistake in their grammar where they should escape it properly

[slevithan]

You're right. They've now fixed it in prisma/language-tools#1807.