Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Storage Version to use v1beta1 #1463

Merged
merged 16 commits into from
Feb 20, 2024

Conversation

qu1queee
Copy link
Contributor

@qu1queee qu1queee commented Jan 8, 2024

Changes

Update SHP Controllers to operate on v1beta1 API resources
Move storage version to v1beta1, instead of v1alpha1
Update webhook conversion functions to come from v1alpha1 instead of v1beta

Fixes #1107

Submitter Checklist

  • Includes tests if functionality changed/was added
  • Includes docs if changes are user-facing
  • Set a kind label on this PR
  • Release notes block has been filled in, or marked NONE

See the contributor guide
for details on coding conventions, github and prow interactions, and the code review process.

Release Notes

Set the storage version to v1beta1 and update Shipwright controllers to operate on the same.

@openshift-ci openshift-ci bot added release-note Label for when a PR has specified a release note do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Jan 8, 2024
@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 8, 2024
@pull-request-size pull-request-size bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 9, 2024
@qu1queee qu1queee closed this Jan 9, 2024
@pull-request-size pull-request-size bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jan 9, 2024
@qu1queee qu1queee reopened this Jan 9, 2024
@pull-request-size pull-request-size bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 9, 2024
@pull-request-size pull-request-size bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 9, 2024
@pull-request-size pull-request-size bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jan 9, 2024
@qu1queee qu1queee force-pushed the qu1queee/issue_1107 branch 6 times, most recently from ee3063a to 3c23b25 Compare January 12, 2024 14:45
@SaschaSchwarze0 SaschaSchwarze0 added this to the release-v0.13.0 milestone Jan 16, 2024
@qu1queee qu1queee closed this Jan 24, 2024
@pull-request-size pull-request-size bot removed the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jan 24, 2024
Ensure logs of mutating webhook are present.
Move it from v1alpha1 to v1beta1 and update CRD's.
Remove unneeded v1alpha1 classes
Ensure status subresource are handle when converting to v1alpha1
move from alpha to beta
move from alpha to beta
For cleanup controllers and strategy ones.

Moving from alpha to beta
Move from alpha to beta
Missing type for Build Source
Move them to beta
Small fix on test/v1beta1_samples files
Fix issue with unknown strategy Kind
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 20, 2024
Multiple items, most important ones:

-Reintroduce source validation for Build
-Reintroduce test case when retention is removed
  from Build
-Fix Build Update predicate for AtBuildDeletion

Signed-off-by: Sascha Schwarze <[email protected]>
Signed-off-by: Sascha Schwarze <[email protected]>
Copy link
Member

@SaschaSchwarze0 SaschaSchwarze0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 20, 2024
Copy link
Contributor

openshift-ci bot commented Feb 20, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SaschaSchwarze0

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 20, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit ebad1d0 into shipwright-io:main Feb 20, 2024
12 checks passed
@qu1queee qu1queee deleted the qu1queee/issue_1107 branch February 20, 2024 08:25
@qu1queee qu1queee restored the qu1queee/issue_1107 branch February 20, 2024 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API lgtm Indicates that a PR is ready to be merged. release-note Label for when a PR has specified a release note size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[BETA API] Update controllers to use Beta API
4 participants