-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Storage Version to use v1beta1 #1463
Update Storage Version to use v1beta1 #1463
Conversation
7988a82
to
a4fe3fa
Compare
a4fe3fa
to
ee89fbf
Compare
30f4529
to
3054897
Compare
17483ea
to
6a770c9
Compare
ee3063a
to
3c23b25
Compare
b8159dc
to
a5ef532
Compare
7c71148
to
ee89fbf
Compare
Ensure logs of mutating webhook are present.
Move it from v1alpha1 to v1beta1 and update CRD's.
Remove unneeded v1alpha1 classes Ensure status subresource are handle when converting to v1alpha1
move from alpha to beta
move from alpha to beta
from alpha to beta
For cleanup controllers and strategy ones. Moving from alpha to beta
Move from alpha to beta
From alpha to beta
Missing type for Build Source
Move them to beta Small fix on test/v1beta1_samples files
Per deprecation
Fix issue with unknown strategy Kind
9b6b886
to
8cc98d1
Compare
8cc98d1
to
6ad9e2c
Compare
Multiple items, most important ones: -Reintroduce source validation for Build -Reintroduce test case when retention is removed from Build -Fix Build Update predicate for AtBuildDeletion Signed-off-by: Sascha Schwarze <[email protected]>
6ad9e2c
to
111e52d
Compare
Signed-off-by: Sascha Schwarze <[email protected]>
111e52d
to
4051f08
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: SaschaSchwarze0 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Changes
Update SHP Controllers to operate on v1beta1 API resources
Move storage version to v1beta1, instead of v1alpha1
Update webhook conversion functions to come from v1alpha1 instead of v1beta
Fixes #1107
Submitter Checklist
See the contributor guide
for details on coding conventions, github and prow interactions, and the code review process.
Release Notes