Fix issue with non-writable sub-directories #1699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
release-note
pull-request-size
bot
added
the
size/M
HeavyWombat
force-pushed
the
fix/permission
branch
from
d50d175
to
89d56f0
Compare
HeavyWombat
force-pushed
the
fix/permission
branch
from
89d56f0
to
0ce8a47
Compare
There are file system setups where there is a file in a directory, but the directory does not have the write bit set (anymore). This kind of setup is perfect fine, however, the bundle logic is unable to unpack it. Fix unpack logic so that it is not setting the file permissions of directories in the moment it creates the directory, but later when all other files are unpacked already and no more write operations are required. Signed-off-by: Matthias Diester <[email protected]>
HeavyWombat
force-pushed
the
fix/permission
branch
from
0ce8a47
to
86c94a1
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: SaschaSchwarze0 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
There are file system setups where there is a file in a directory, but the directory does not have the write bit set (anymore). This kind of setup is perfect fine, however, the bundle logic is unable to unpack it.
Fix unpack logic so that it is not setting the file permissions of directories in the moment it creates the directory, but later when all other files are unpacked already and no more write operations are required.
/kind bug
Submitter Checklist
See the contributor guide
for details on coding conventions, github and prow interactions, and the code review process.
Release Notes