Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump onsi/ginkgo, onsi/gomega, and golang.org/x dependencies #1707

Closed
wants to merge 1 commit into from

Conversation

HeavyWombat
Copy link
Contributor

Changes

Bump github.com/onsi/ginkgo and github.com/onsi/gomega to latest available versions.

Submitter Checklist

  • Includes tests if functionality changed/was added
  • Includes docs if changes are user-facing
  • Set a kind label on this PR
  • Release notes block has been filled in, or marked NONE

See the contributor guide
for details on coding conventions, github and prow interactions, and the code review process.

Release Notes

NONE

Bump `github.com/onsi/ginkgo` and `github.com/onsi/gomega` to latest
available versions.

Signed-off-by: Matthias Diester <[email protected]>
@HeavyWombat HeavyWombat added the kind/dependency-change Categorizes issue or PR as related to changing dependencies label Oct 30, 2024
@openshift-ci openshift-ci bot added the release-note-none Label for when a PR does not need a release note label Oct 30, 2024
Copy link
Contributor

openshift-ci bot commented Oct 30, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from heavywombat. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 30, 2024
@HeavyWombat HeavyWombat changed the title Bump onsi/ginkgo and onsi/gomega dependencies Bump onsi/ginkgo, onsi/gomega, and golang.org/x dependencies Oct 30, 2024
@SaschaSchwarze0
Copy link
Member

@HeavyWombat why do you PR this? DependaBot has opened PRs for Ginkgo and Gomega already.

@HeavyWombat
Copy link
Contributor Author

HeavyWombat commented Oct 30, 2024

@HeavyWombat why do you PR this? DependaBot has opened PRs for Ginkgo and Gomega already.

Wanted to test something with regards to the updates of the golang.org/x updates and Go/Toolchain updates that come along side the Ginkgo ones and since the other ones were red anyway, I just clicked the create PR.

More specifically, I wonder if we can (and or should) get the toolchain directive updates out of Dependabot, because it then depends on the build process whether they overrule that or not with local toolchain.

@HeavyWombat HeavyWombat deleted the bump/deps branch October 30, 2024 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/dependency-change Categorizes issue or PR as related to changing dependencies release-note-none Label for when a PR does not need a release note size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants