Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use proper logging #18

Open
acelaya opened this issue May 6, 2024 · 1 comment
Open

Use proper logging #18

acelaya opened this issue May 6, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@acelaya
Copy link
Member

acelaya commented May 6, 2024

The server is currently logging some lines via console.log. Use a proper logging service instead.

@acelaya acelaya added the enhancement New feature or request label May 6, 2024
@acelaya acelaya added this to Shlink May 6, 2024
@twigmac
Copy link

twigmac commented Feb 4, 2025

Using console.log should actually be fine IMO. If you run the app in a container the logs can be flexibly forwarded to any log monitoring service of your choice. If you, however, incorporate that directly into the app, you will add a (maybe later difficult to remove) dependency and add extra load to the app and you might not be able to trace back the log event to the running container instance (if you have multiple instances). In any case, the biggest challenge is to decide which info goes into which channel (debug, warn, log, error), such that the logs can be meaningfully filtered and do not flood your monitoring.

Btw.: Great work! 🚀 If you'd drop a CONTRIBUTING.md file to know how to contribute that would be awesome and also maybe label issues with "contribution welcome" or so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: No status
Development

No branches or pull requests

2 participants