Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added comments to the algerian.py #401

Merged
merged 4 commits into from
Oct 17, 2024
Merged

Added comments to the algerian.py #401

merged 4 commits into from
Oct 17, 2024

Conversation

Surani02
Copy link
Contributor

I have added comments to the algerian.py file to make it easier to understand.

@joeraz
Copy link
Collaborator

joeraz commented Oct 16, 2024

Please check the code to make sure it passes flake8 validation. It looks like some lines are too long.

I made changes to the code so that it would pass flake8.
@joeraz
Copy link
Collaborator

joeraz commented Oct 17, 2024

It looks like the validation is still failing. See https://github.com/shlomif/PySolFC/actions/runs/11368458911/job/31626231642?pr=401 - the comments listed here should be split onto a second line.

I have revised the comments to comply with Flake8 standards.
I have removed the trailing spaces to ensure AppVeyor passes successfully.
@joeraz
Copy link
Collaborator

joeraz commented Oct 17, 2024

Looks good, thank you!

Merging.

@joeraz joeraz merged commit cc32c03 into shlomif:master Oct 17, 2024
2 checks passed
@Surani02
Copy link
Contributor Author

Thank you for being so supportive!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants