From 8515dddcc65e4febfc3fa449582da4c627e991e3 Mon Sep 17 00:00:00 2001
From: Stephane Raynaud <stephane.raynaud@shom.fr>
Date: Thu, 27 Jun 2024 12:00:44 +0200
Subject: [PATCH] Fix weighting of convolve

---
 CHANGES.rst   |  1 +
 xoa/filter.py | 25 ++++++++++++++-----------
 2 files changed, 15 insertions(+), 11 deletions(-)

diff --git a/CHANGES.rst b/CHANGES.rst
index 107a6ef..12f2b31 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -20,6 +20,7 @@ Deprecations
 
 Bug fixes
 ---------
+- Fix weighting of :func:`xoa.filter.convolve`.
 - Fix :func:`xoa.grid.to_rect` raising of errors and handling of missing data in coordinates.
 - Fix string formatting in :func:`xoa.filter.tidal_filter` warning.
 
diff --git a/xoa/filter.py b/xoa/filter.py
index 639f562..89d34fa 100644
--- a/xoa/filter.py
+++ b/xoa/filter.py
@@ -99,7 +99,7 @@
         3,
         1,
     ],
-    "godin":[
+    "godin": [
         1,
         3,
         6,
@@ -172,7 +172,7 @@
         3,
         1,
     ],
-    "mean":[
+    "mean": [
         1,
         1,
         1,
@@ -198,8 +198,7 @@
         1,
         1,
         1,
-    ]
-
+    ],
 }
 
 
@@ -538,7 +537,11 @@ def generate_kernel(
             if isotropic is True:
                 isotropic = data.dims
             elif not set(isotropic).issubset(data.dims):
-                raise XoaError("invalid dimensions for isotropic keyword")
+                raise XoaError(
+                    "Invalid dimensions for isotropic keyword: {}".format(
+                        set(isotropic) - set(data.dims)
+                    )
+                )
 
         # Split into consistant isotropic and orthogonal kernels
         isokernels_sizes = {}
@@ -562,7 +565,7 @@ def generate_kernel(
                         and not np.isscalar(isokernel)
                         and not np.allclose(kn, isokernel)
                     ):
-                        raise XoaError("Inconsistant 1d kernels for building " "isotropic kernel")
+                        raise XoaError("Inconsistant 1d kernels for building isotropic kernel")
                 else:
                     isokernel = kn
                 size = kn if np.isscalar(kn) else len(kn)
@@ -604,7 +607,7 @@ def generate_kernel(
     elif isinstance(kernel, np.ndarray):
         if kernel.ndim > data.ndim:
             raise XoaError(
-                "too many dimensions for your numpy kernel: {} > {}".format(kernel.dim, data.ndim)
+                "Too many dimensions for your numpy kernel: {} > {}".format(kernel.dim, data.ndim)
             )
         dims = data.dims[-kernel.ndim :]
 
@@ -612,7 +615,7 @@ def generate_kernel(
     if not isinstance(kernel, xr.DataArray):
         kernel = xr.DataArray(kernel, dims=dims)
     elif not set(kernel.dims).issubset(set(data.dims)):
-        raise XoaError(f"kernel dimensions {kernel.dims} " f"are not a subset of {data.dims}")
+        raise XoaError(f"Kernel dimensions {kernel.dims} are not a subset of {data.dims}")
 
     # Finalize
     kernel = kernel.astype(data.dtype)
@@ -684,7 +687,7 @@ def _convolve_(data, kernel, normalize, na_thres, axis=None):
 
     # Convolutions
     cdata = convolve_func(data, kernel, cval=0.0, **kwc)
-    weights = convolve_func((~bad).astype('i'), kernel, cval=0, **kwc)
+    weights = convolve_func((~bad).astype('d'), kernel, cval=0, **kwc)
     # weights = np.clip(weights, 0, kernel.sum())
 
     # Weigthing and masking
@@ -854,7 +857,7 @@ def erode_mask(data, until=1, kernel=None):
     else:
         mask = until
         if not set(mask.dims).issubset(data.dims):
-            raise XoaError('mask dims must be a subset of data dims')
+            raise XoaError('Mask dims must be a subset of data dims')
         mask = xcoords.transpose(mask, data, mode="compat")
 
     # Filter
@@ -915,7 +918,7 @@ def erode_coast(data, until=1, kernel=None, xdim=None, ydim=None):
     if isinstance(kernel, xr.DataArray):
         assert xdim in kernel.dims, f"kernel must have dimension: {xdim}"
         assert ydim in kernel.dims, f"kernel must have dimension: {ydim}"
-    elif kernel is None or kernel == "shapiro":
+    elif kernel is None or (isinstance(kernel, str) and kernel == "shapiro"):
         kernel = shapiro_kernel((ydim, xdim))
 
     # Mask array