-
Notifications
You must be signed in to change notification settings - Fork 458
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update TextInput.js #550
base: develop
Are you sure you want to change the base?
Update TextInput.js #550
Conversation
Fix for onFocus & onBlur silently failing when using handling both methods
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great thinking, somehow it didn't occur to me that people would want to include their own specific onFocus
and onBlur
. Just an oversight.
@@ -22,12 +22,13 @@ class TextInput extends PureComponent { | |||
|
|||
handleBlur() { | |||
this.setState({ isFocused: false }); | |||
this.props.onBlur() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Destructure onBlur
from this.props
on the first line of the method with a fallback to null
if it isn't set. This should be followed by a newline. Then check if onBlur
is truthy and run it:
handleBlur() {
const { onBlur = null } = this.props;
this.setState({ isFocused: false });
if (onBlur) {
onBlur();
}
}
} | ||
|
||
handleFocus() { | ||
this.setState({ isFocused: true }); | ||
this.props.onFocus() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Destructure onFocus
from this.props
on the first line of the method with a fallback to null
if it isn't set. This should be followed by a newline. Then check if onFocus
is truthy and run it:
handleFocus() {
const { onFocus = null } = this.props;
this.setState({ isFocused: true });
if (onFocus) {
onFocus();
}
}
} | ||
|
||
render() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reintroduce this newline between handleFocus
and render
, we separate all methods with a newline.
Fix for onFocus & onBlur silently failing. Reproduction example below...