Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rocket Launch Products Stack Size #381

Open
davqvist opened this issue Jan 1, 2025 · 0 comments
Open

Rocket Launch Products Stack Size #381

davqvist opened this issue Jan 1, 2025 · 0 comments
Labels
bug Something isn't working

Comments

@davqvist
Copy link

davqvist commented Jan 1, 2025

YAFC 2.5.0

In a world where there is SA enabled but also there exists a recipe with launch products (like white science w/o SA), YAFC takes into account the stack size to launch the product, not the rocket capacity. It should take the rocket capacity into account instead.

Can't provide an example as I am using an in dev mod of mine where I encountered this, sorry. But I hope issue is pretty clear.
I can provide a screenshot though if that helps.
image
Here 200 black science is gotten from 1 Space Data but the Space Data has a stack size of 10 but a rocket capacity of 1 which leads to 10 times less rocket launches as required.
@davqvist davqvist added the bug Something isn't working label Jan 1, 2025
@DaleStan DaleStan mentioned this issue Jan 11, 2025
Merged
shpaass added a commit that referenced this issue Jan 24, 2025
@shpaass
Calculate item weight and display rocket capacity (#387)
a49113c 
This loads or calculates the weight of each item and displays the rocket
capacity in the item tooltips. I don't think this completes either #369
or #381, but it loads data needed for them.

The calculations done by Factorio aren't documented, but most of my
results match at least one of https://rocketcal.cc/weights.json or
Factorio. (I skipped some harder-to-acquire items, such as the
spidertron rocket launchers, and all virtual items, such as artillery
remotes.)
DaleStan added a commit to DaleStan/yafc that referenced this issue Feb 4, 2025
@DaleStan
fix(shpaass#381): Rocket launch recipes use rocket capacity, not stac…
09d1e8c 
…k size.
DaleStan added a commit to DaleStan/yafc that referenced this issue Feb 4, 2025
@DaleStan
fix(shpaass#381): Rocket launch recipes use rocket capacity, not stac…
2ff5108 
…k size.
shpaass added a commit that referenced this issue Feb 4, 2025
@shpaass
fix(#381): Rocket launch recipes use rocket capacity, not stack size. (…
f3603ca 
…#406)

Py launch recipes now consume 5 items, instead of 1, and scale up their
output accordingly.

The satellite and space platform launch recipes are still correct. Fish
launch goes to 300 in SA instead of 100 in vanilla, but that's both a
rarely-modeled recipe and a justifiable result.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@davqvist