Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to update a localcourse that is mapped to a partner course #10

Open
shuyangk opened this issue Nov 17, 2023 · 1 comment
Open

Comments

@shuyangk
Copy link
Owner

shuyangk commented Nov 17, 2023

When attempting to update a localcourse that is currently mapped, the application disallows this, and the mapping has to be deleted first. However this might cause inconvenience for users if the course to be updated is mapped to many other courses, and they have to delete all mappings before being able to update the local course.
Maybe updating a local course that is mapped to other courses should be allowed, and the mapping itself should be updated by the application.

image.png

@nus-pe-bot
Copy link

nus-pe-bot commented Nov 20, 2023

Team's Response

One of our planned enhancements: Add the ability to allow update of mappings, to complement the existing mapping feature. This was not prioritised due to time constraints.

To update a mapped local course code / partner course code (the primary keys), we have to update the corresponding code in the mappings (foreign key) too which falls under 'updating of mapping'.

We only allow updating of local name, local unit and local description of local courses.

Due to planned enhancements, this was intended, or else it will cause other bugs related to updating of mapping.

Items for the Tester to Verify

❓ Issue response

Team chose [response.Rejected]

  • I disagree

Reason for disagreement: From the planned enhancements stated in the DG, it is interpreted as allowing updates to the mappings, (i.e editing of mappings), since the ability to edit mappings is currently not present. However this issue is related to the updating of local courses, which is a separate action from changing the mappings. The way the planned enhancement was stated is not clear to the reader who is only reading the DG for information.

image.png


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants