Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Branch node does not follow course standards #15

Open
shuyangk opened this issue Nov 17, 2023 · 1 comment
Open

Branch node does not follow course standards #15

shuyangk opened this issue Nov 17, 2023 · 1 comment

Comments

@shuyangk
Copy link
Owner

shuyangk commented Nov 17, 2023

In the course, it is mentioned that branch nodes should be empty inside, with branch conditions written on the outside, however the below activity diagram violates this.

image.png

@nus-se-bot
Copy link

nus-se-bot commented Nov 21, 2023

Team's Response

Does not hinder the user, doesn't affect usage as it doesn't change the meaning. (another notation)

Items for the Tester to Verify

❓ Issue severity

Team chose [severity.VeryLow]
Originally [severity.Low]

  • I disagree

Reason for disagreement: While if simply a standalone notation error, it might fall under the VeryLow categorization, however according to the guidelines, notation errors can hurt the credibility of diagrams, and as there are multiple separate notation errors across various diagrams, I believe the severity should be Low.

image.png


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants