feat: address various points after review #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
utkuozdemir
force-pushed
the
refactor
branch
3 times, most recently
from
f066e4d to
92f0c44
Compare
- Allow "--clear-state" flag only on debug builds. - Remove the `baremetal.MachineStatus` resources when an `infra.Machine` is being torn down, so that these resources do not accumulate. - Build Omni join config using machinery, not template. - Various renames and small refactorings. - Change the way we persist the logs on integration tests. - Ensure that we tear down the spawned QEMU machines at the end of integration tests. - Reuse the machine ID header key by importing it from the agent repo. - Disable building images of `qemu-up` binary. - Bump Go, deps and rekres. Signed-off-by: Utku Ozdemir <[email protected]>
utkuozdemir
commented
Dec 7, 2024
| @@ -13,7 +13,7 @@ type Options struct { | |||
| OmniAPIEndpoint string | |||
| ImageFactoryBaseURL string | |||
| ImageFactoryPXEBaseURL string | |||
| AgentModeTalosVersion string | |||
| AgentModeTalosVersion string // todo: get this from Omni. Warning: needs to be Talos 1.9 with agent code inside | |||
There was a problem hiding this comment.
This is something I'm going to do later
Unix4ever
approved these changes
Dec 9, 2024
|
/m |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
baremetal.MachineStatusresources when aninfra.Machineis being torn down, so that these resources do not accumulate.qemu-upbinary.