Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: implement machine acceptance #773

Closed
Tracked by #757
utkuozdemir opened this issue Dec 9, 2024 · 0 comments · Fixed by #790
Closed
Tracked by #757

UI: implement machine acceptance #773

utkuozdemir opened this issue Dec 9, 2024 · 0 comments · Fixed by #790
Assignees

Comments

@utkuozdemir
Copy link
Member

utkuozdemir commented Dec 9, 2024

Ideas:

  • accept/reject buttons on a screen
  • maybe machines screen
  • maybe separate screen with "X pending machines"
@utkuozdemir utkuozdemir changed the title Machine acceptance: accept/reject buttons on a screen, maybe machines screen, maybe separate screen with "X pending machines" UI: implement machine acceptance Dec 9, 2024
@Unix4ever Unix4ever self-assigned this Dec 16, 2024
Unix4ever added a commit to Unix4ever/omni that referenced this issue Dec 17, 2024
It is now possible to filter the machine by the following categories in
the UI:
- Manually joined machines.
- Machines provisioned by the infra providers.
- Machines PXE booted through the metal provider.
- Machines discovered by the metal provider, but not yet accepted by the
  system.

Machine acceptance UI also has two new modal windows for accepting and
rejecting the machines.
Also update controllers to add labels to the not accepted infra
machines.

Fixes: siderolabs#773
Fixes: siderolabs#766

Signed-off-by: Artem Chernyshev <[email protected]>
Unix4ever added a commit to Unix4ever/omni that referenced this issue Dec 17, 2024
It is now possible to filter the machine by the following categories in
the UI:
- Manually joined machines.
- Machines provisioned by the infra providers.
- Machines PXE booted through the metal provider.
- Machines discovered by the metal provider, but not yet accepted by the
  system.

Machine acceptance UI also has two new modal windows for accepting and
rejecting the machines.
Also update controllers to add labels to the not accepted infra
machines.

Fixes: siderolabs#773
Fixes: siderolabs#766

Signed-off-by: Artem Chernyshev <[email protected]>
Unix4ever added a commit to Unix4ever/omni that referenced this issue Dec 17, 2024
It is now possible to filter the machine by the following categories in
the UI:
- Manually joined machines.
- Machines provisioned by the infra providers.
- Machines PXE booted through the metal provider.
- Machines discovered by the metal provider, but not yet accepted by the
  system.

Machine acceptance UI also has two new modal windows for accepting and
rejecting the machines.
Also update controllers to add labels to the not accepted infra
machines.

Fixes: siderolabs#773
Fixes: siderolabs#766

Signed-off-by: Artem Chernyshev <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants