Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] S3 Backup Configuration Fails with Incorrect Endpoint #891

Open
1 task done
utkuozdemir opened this issue Jan 31, 2025 · 0 comments
Open
1 task done

[bug] S3 Backup Configuration Fails with Incorrect Endpoint #891

utkuozdemir opened this issue Jan 31, 2025 · 0 comments
Labels
bug Something isn't working

Comments

@utkuozdemir
Copy link
Member

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

S3 backup configuration fails with the following error when saving credentials:

Failed to Update Storage Config
failed to validate: 1 error occurred: * incorrect settings for s3 client: failed to list objects in bucket "***": operation error S3: ListObjects, https response error StatusCode: 404, RequestID: ..., api error NoSuchKey: The specified key does not exist.

Investigation & Findings

  • Credentials tested successfully using:
    aws s3 ls s3://****/
    This confirms the bucket exists and is accessible.
  • Issue identified with the endpoint:
    • Setting the endpoint to https://***.s3.us-east-1.amazonaws.com caused failures.
    • Setting no endpoint resulted in an invalid URI error.
    • Fix: Using https://s3.amazonaws.com as the endpoint resolved the issue.
  • Root Cause: us-east-1 is a legacy region with a region-less endpoint. The SDK should determine the endpoint automatically.

Suggested Fix

  • Allow AWS SDK to automatically determine the endpoint when none is provided.
  • Ensure that setting an explicit endpoint is only necessary for non-standard S3-compatible storage.

Expected Behavior

It to not fail.

Steps To Reproduce

  1. Navigate to Settings > Backups in Sidero Omni.
  2. Configure the S3 storage with the following values:
    • Endpoint: https://****.s3.us-east-1.amazonaws.com
    • Bucket: ****
    • Region: us-east-1
    • Access Key ID and Secret Access Key: (valid credentials)
  3. Click Save.
  4. Observe the failure message indicating NoSuchKey or Custom endpoint was not a valid URI.

What browsers are you seeing the problem on?

No response

Anything else?

No response

@utkuozdemir utkuozdemir added the bug Something isn't working label Jan 31, 2025
@alongwill alongwill pinned this issue Jan 31, 2025
@alongwill alongwill unpinned this issue Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant