Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FEAT added pagination to food banks #14

Closed
wants to merge 6 commits into from
Closed

FEAT added pagination to food banks #14

wants to merge 6 commits into from

Conversation

Ronald545
Copy link
Contributor

@Ronald545 Ronald545 commented Jul 14, 2021 •
edited
Loading

added pagination and fake loading animation to food banks

Screen.Recording.2021-07-14.at.10.47.37.AM.mov

[x] my change doesn't break anything

@sidharrth2002

@vercel
Copy link

vercel bot commented Jul 14, 2021

Someone is attempting to deploy a commit to a Personal Account owned by @sidharrth2002 on Vercel.

@sidharrth2002 first needs to authorize it.

@sidharrth2002
Copy link
Owner

The loading icon could it be transparent and smaller?

@Ronald545
Copy link
Contributor Author

added smaller and transparent icon @sidharrth2002

@Shaunmak1214
Copy link
Collaborator

Maybe we could make use of chakra spinner, skeleton component for this https://chakra-ui.com/docs/feedback/skeleton, https://chakra-ui.com/docs/feedback/spinner. I can add it if there's an agreement.

@sidharrth2002
Copy link
Owner

Maybe we could make use of chakra spinner, skeleton component for this https://chakra-ui.com/docs/feedback/skeleton, https://chakra-ui.com/docs/feedback/spinner. I can add it if there's an agreement.

This will be cleaner yes

@sidharrth2002 sidharrth2002 added the enhancement New feature or request label Jul 18, 2021
@sidharrth2002
Copy link
Owner

Will have a look. Thanks Ronald!

@sidharrth2002 sidharrth2002 linked an issue Jul 21, 2021 that may be closed by this pull request
Food banks list pagination #68
Open
@sidharrth2002
Copy link
Owner

@Shaunmak1214 if you're free, could you check if this is good to merge?

@Shaunmak1214
Copy link
Collaborator

@sidharrth2002 will do it tonight yeah, sorry for the delay

@sidharrth2002 sidharrth2002 linked an issue Jul 23, 2021 that may be closed by this pull request
Add chakra loader on food banks list pagination, and some css enhancements #55
Open
@sidharrth2002
Copy link
Owner

In favour of Chakra spinner and the PR becoming stale, will put on the backburner for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shaunmak1214 Shaunmak1214 Awaiting requested review from Shaunmak1214

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Food banks list pagination Add chakra loader on food banks list pagination, and some css enhancements
3 participants
@Ronald545 @sidharrth2002 @Shaunmak1214