-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
get_playlist track artists are now None #627
Comments
So yet another case, that I have to adapt to the new logic, this time it's videos uploaded from non-official user channels. I guess initially in 1.7.4 it worked, but then I fixed albums (#618) and I broke this one. I will revert my fix from #618 and I will remove the new logic for albums, bringing back preset flexColumn meanings. What do you think? @sigma67 P.S. I know we need tests for all these cases, but tbh I am not sure how to design them. |
Reverting the fix won't help because then you break the other use cases again. Good tests would be to add asserts on the existing tests. For all tests with static album and playlist ids (where tracks are known to have artists), add an assert that ensures the artist is parsed correctly |
What I meant is removing the new logic, but only for albums (see: 3208ca9). So for albums columns are hardcoded and for playlist they are still resolved using There are border cases with columns without |
I see, that's fine. Please also consider the |
Describe the bug
In version 1.7.5, the value of
artists
in alltracks
items inget_playlist()
data is alwaysNone
. This is not the case in 1.7.4.To Reproduce
Additional context
1.7.4:
1.7.5:
Because of this there is no way to get artist information from a playlist in 1.7.5.
The text was updated successfully, but these errors were encountered: