Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Help tab to the Preferences #5898

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

yusufsahinhamza
Copy link
Contributor

@yusufsahinhamza yusufsahinhamza commented Apr 27, 2022

Contributor checklist:

Description

  • "Help" tab is added to the "Preferences" just like in Signal's mobile apps.
  • For now "Help" tab shows current app version and has redirect links to "Support Center" and "Terms & Privacy Policy" pages of Signal website.
  • Icons are downloaded from Signal-iOS repository
  • Tested at "22 April 2023" with "macOS Ventura 13.3.1".

Screenshot:

help_tab

@josh-signal
Copy link
Contributor

We're taking a look at this.

@yusufsahinhamza
Copy link
Contributor Author

@josh-signal Any update?

@josh-signal
Copy link
Contributor

Sorry it's taking so long, design is still having a look.

@stale
Copy link

stale bot commented Oct 25, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Oct 25, 2022
@stale
Copy link

stale bot commented Nov 2, 2022

This issue has been closed due to inactivity.

@stale stale bot closed this Nov 2, 2022
@yusufsahinhamza
Copy link
Contributor Author

@josh-signal This pull request has been closed by stale bot but i think we still need it, what do you think?

@josh-signal josh-signal reopened this Apr 22, 2023
@stale stale bot removed the stale label Apr 22, 2023
@yusufsahinhamza yusufsahinhamza force-pushed the add_preferences_help_tab branch 3 times, most recently from bf942f7 to acd1a83 Compare April 22, 2023 16:08
@yusufsahinhamza
Copy link
Contributor Author

acd1a831ec6ed00a2ffeccafde948f370d596329 rebased and conflicts are solved.

@stale
Copy link

stale bot commented Aug 21, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Aug 21, 2023
@yusufsahinhamza
Copy link
Contributor Author

yusufsahinhamza commented Aug 21, 2023

@josh-signal Hello again, stale bot is trying to close the pull request due inactivity, i think context of this pull request is fairly plain and easy to review, can you tell me whether or not this pull request is going to be merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants