Don't show sticker picker when replying to a message #7065
+29
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hackerbirds
force-pushed
the
hide-sticker-picker
branch
from
a2537cb
to
b346626
Compare
Stickers can't be used as a reply to message, so this led to UX confusion
hackerbirds
force-pushed
the
hide-sticker-picker
branch
from
b346626
to
5d899d7
Compare
hackerbirds
changed the title
|
Sorry about this mess, I rebased and pushed without including my changes lol I changed the logic a bit. Now it prevents showing the sticker picker only in the reply case. My previous changes were too broad--only the reply scenario was confusing from a UX standpoint! Cases like draft messages or attachments now behave the same as before, and users can use the sticker picker in those cases, as I believe it's not confusing that you can send stickers without including your draft message or attachment along with it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The sticker picker could be opened when the user is about to send an attachment, or a reply, or text, neither of which can be combined with stickers.
I have personally witnessed many users thinking they could reply to a message with a sticker, then be surprised when the sticker they sent does not include the reply. This change makes it clear that you cannot send stickers as a reply to a message, or with text/attachments. Note that this behavior follows what iOS is doing, and I think Android should do the same.
First time contributor checklist:
Contributor checklist:
mainbranchnpm run readyrun passes successfully (more about tests here)Description