Lightbox: Added Button to jump to current image within the conversation #7098
+59
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
findus
force-pushed
the
jump-to-image
branch
3 times, most recently
from
47974c5
to
98b0a13
Compare
findus
force-pushed
the
jump-to-image
branch
from
98b0a13
to
ac26daf
Compare
Lightbox: moved conversationId references to new authorId reference save authorId and conversationId separately
findus
commented
Nov 22, 2024
| e164: message.get('source'), | ||
| reason: 'conversation_view.showLightBox', | ||
| })?.id || message.get('conversationId'); | ||
| const authorId = getAuthorId(message); |
There was a problem hiding this comment.
I had the problem here that the conversationId gets set as the authorId, the conversation id only gets set as fallback when "window.ConversationController.lookupOrCreate" is null/undefined.
But for this functionality I always need the conversationId, so I introduced a new variable "authorId" and replaced all previous usages with that one.
Is it intended that the variable got set like this in the first place and is there a gotcha that I haven't seen?
jamiebuilds-signal
requested review from
jamiebuilds-signal and
ayumi-signal
and removed request for
jamiebuilds-signal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First time contributor checklist:
Contributor checklist:
My contribution is not related to translations.
My commits are in nice logical chunks with good commit messages
My changes are rebased on the latest
mainbranchA
npm run readyrun passes successfully (more about tests here)(Linting errros but in node_modules)
My changes are ready to be shipped to users
Description
Adds a "jump to conversation" button to the Media-Lightbox to jump to the position in the conversation where the image was used.