Skip to content
This repository has been archived by the owner on Feb 12, 2022. It is now read-only.

Current code is not compatible with code in Contact Discovery Service (CDS) #78

Open
kvishnivetsky opened this issue Nov 6, 2019 · 6 comments

Comments

@kvishnivetsky
Copy link

Hi!

CDS requires libsignal-service-java version 2.7.8, but there is only verion 2.15.0 of libsignal-service-java available or 1.8.6(by tags).
2.15.0 has incomaptible class interface.

Let's decide how to resolve this issue.

@alan-signal
Copy link
Contributor

alan-signal commented Nov 13, 2019

"CDS requires libsignal-service-java version 2.7.8"

do you have a link to that reference in CDS?

@kvishnivetsky
Copy link
Author

"CDS requires libsignal-service-java version 2.7.8"

do you have a link to that reference in CDS?

Yes. It is located in one of project XML files.

We got source code from:
https://github.com/signalapp/libsignal-service-java

@alan-signal
Copy link
Contributor

You gave me a link to this project.

I wanted a link to the specific xml file that references 2.7.8 inside the CDS project that you are talking about.

@kvishnivetsky
Copy link
Author

https://github.com/signalapp/ContactDiscoveryService/blob/master/client/pom.xml#L32

      <dependency>
           <groupId>org.whispersystems</groupId>
           <artifactId>signal-service-java</artifactId>
           <version>2.7.8</version>
       </dependency>

You gave me a link to this project.

I wanted a link to the specific xml file that references 2.7.8 inside the CDS project that you are talking about.

@alan-signal
Copy link
Contributor

I did search with github and it didn't find 2.7.8 or lib signal so thanks for the link. Will mention internally, in the meantime try 2.7.7 or 2.8.0

image

@kvishnivetsky
Copy link
Author

I did search with github and it didn't find 2.7.8 or lib signal so thanks for the link. Will mention internally, in the meantime try 2.7.7 or 2.8.0

image

We tryed several versions of signal-service-java (by tags) and version tagged as v1.3 (A.K.A. 2.13.0) fits. Projects is belt successfully.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

No branches or pull requests

2 participants