Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slow system spurious TestSignDetached self-check failures #624

Open
jas4711 opened this issue Jan 22, 2025 · 0 comments
Open

Slow system spurious TestSignDetached self-check failures #624

jas4711 opened this issue Jan 22, 2025 · 0 comments
Labels
bug Something isn't working

Comments

@jas4711
Copy link

jas4711 commented Jan 22, 2025

Hi! I'm packaging this for Debian, and on our riscv64 builds, I got this self-test failure:

    sign_test.go:102: expected SigningTime to be now. Difference was -1.020778821s
--- FAIL: TestSignDetached (0.02s)

See: https://buildd.debian.org/status/fetch.php?pkg=gitsign&arch=riscv64&ver=0.12.0-3&stamp=1737565102&raw=0

I suspect this is triggered by this platform being really slow. From the error messages, maybe something is taking more than 1 second and this trigger a time comparison mismatch?

Could you make the allowed time window a bit larger? Say 5 seconds instead of 1 second?

/Simon

@jas4711 jas4711 added the bug Something isn't working label Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant