Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General problems #830

Open
jotakar opened this issue Oct 25, 2018 · 3 comments
Open

General problems #830

jotakar opened this issue Oct 25, 2018 · 3 comments

Comments

@jotakar
Copy link
Contributor

jotakar commented Oct 25, 2018

I've found new problems when I try to use this app. All about the edit process:

  • The text editor, a good attempt to get a confortable editor, but ... when you edit a text all the styles dissapear and it's necesary to begin again and recreate the original style.
  • Cannot assign class to boxes or texts or images. Great: you can create classes with css editor, but you can not use them. Class box for styles is empty. Almost every element selected has the same style: .element
  • If you have a <header> block in a template, the web page created from this template change this <header> into a <div>.
  • Cannot add html container (navs, asides, header)
  • When select any dom element the properties are not updated in tool boxes (right tool box panel). You can select an image and you cannot see the src or its properties.
    I'm using last version cloned and installed from develop branch.
    I don't know if this problems need big or little changes in code. The lack of cocumetnation is an added obstacle when looking for solutions.
    Any help or comment or help?
    Thanks
@lexoyo
Copy link
Member

lexoyo commented Oct 26, 2018

Thank you for the feedback
I assume you are testing preprod.silex.me ?

  • The text editor, a good attempt to get a confortable editor, but ... when you edit a text all the styles dissapear and it's necesary to begin again and recreate the original style.

What do you mean? Is this a bug or the UX?

  • Cannot assign class to boxes or texts or images. Great: you can create classes with css editor, but you can not use them. Class box for styles is empty. Almost every element selected has the same style: .element

I'm not sure to understand... Are you talking about the css editor in the property panel?

The .element is there to indicate this is the css styles of the element. You are supposed to create a css class of your own like my-class here:
screenshot from 2018-10-26 12-07-45

And then use it in the CSS editor like this:
screenshot from 2018-10-26 12-09-31

The question if we should remove the CSS styles block from the side bar has been asked but some people use it

  • If you have a <header> block in a template, the web page created from this template change this <header> into a <div>.
  • Cannot add html container (navs, asides, header)

This is a feature we should develop
It is not that complicated, you may try to implement it if you want?
There should be a "tag" property in the side bar with the list of available html tags

  • When select any dom element the properties are not updated in tool boxes (right tool box panel). You can select an image and you cannot see the src or its properties.

I am not sure but I think you are talking about the fact that the src is not editable? You would like to have a text input with the image url?

I don't know if this problems need big or little changes in code. The lack of cocumetnation is an added obstacle when looking for solutions.

Sure, I should create developer docs... I started here, let me know what would help you, and I will write it there for you
https://github.com/silexlabs/Silex/wiki/Silex-Developer-Guide

@jotakar
Copy link
Contributor Author

jotakar commented Oct 26, 2018

After read your post I understand that preprod is the develop branch (that's a beta?), and the old version is master branch (that's alfa). Well I'm working with develop branche (the defaul branch I see here in github).
I begin with the last :) I like this document. A project like that his a good documentation. It needs to grow up but it's a good begining
Take foods & drinks templates as an example.
Select the title box (Foods & Drinks): do you see its class anywhere?
Now edit it, what happened? Its style has dissapeared, and how do you know wich were its class or styles?
Looking in source code I see its a header eith class title, but even if I set class title in Styles box of right panel, I don't see the original.
I look for title class using the css editor and the class is ther, fine, but it's different from .element chown when I select the box. With title box selected I see:
image
And the title class is
image
More, select an item nav, in this case you can see its class but there is again differences between the css box and the css editor.
Select an image, the style box shows css properties but some of them doesn't correspond with we see in panel. Compare border properties with an image selected.
image
Select a text box, which is its font-family or its classes? (about font family I have an idea exposed in other post ...)

So sometimes selected doms elements don't show its properties in right panel, or not the whole properties or actual classes or styles.

Suggestions:
Classes edited in css editor could be shown in drop down lists, like font-weight or the text styles, multi select perhaps.
The idea about a "tag" property in the side bar is good, at least for containers type, not just div and section.
A selector for sources images, backgrounds... Something like a window ...
image

Perhaps they are too much notes for a post ;(.
But the program is good and this preprod version looks like very good. I think that after this problems are solved the product would be the best.

Thanks.

@lexoyo
Copy link
Member

lexoyo commented Oct 26, 2018

After read your post I understand that preprod is the develop branch (that's a beta?), and the old version is master branch (that's alfa). Well I'm working with develop branche (the defaul branch I see here in github). I begin with the last :)
I like this document. A project like that his a good documentation. It needs to grow up but it's a good begining

Ok cool, so to start collaborating on the document, I have added this to the developer guide in Silex wiki here:

Silex source code repository is organized with 2 git branches:

  • master is the stable version in production, for example on editor.silex.me
  • develop is the "preprod" or next version to come, and it is live on preprod.silex.me for anyone to test (this is a good contribution, thx in advance)

Select the title box (Foods & Drinks): do you see its class anywhere?
Now edit it, what happened? Its style has dissapeared, and how do you know wich were its class or styles?
Looking in source code I see its a header eith class title, but even if I set class title in Styles box of right panel, I don't see the original.
I look for title class using the css editor and the class is ther, fine, but it's different from .element chown when I select the box. With title box selected I see:
image

Oh ok I see what you mean now!!
This is because the templates do not use the new style editor for now, I'm converting them slowly and I'll update them soon. What I do with them is

  • create a "All Style" default style for all texts
  • add embedded font in the new fonts section of the settings dialog
  • remove all the css text styles from the CSS editor
  • cleanup and make sure they use components and not HTML boxes for contact forms and maps

The only one which has that on preprod for now is the blank template

A selector for sources images, backgrounds... Something like a window

Ok, nice!
I think this should be the image selection mode of Cloud Explorer... It has already the info that we are selecting an image (it filters the other types of files). It should display the images in this case instead of the file names? Or I had this idea which is close and maybe better for loading time and bandwidth?
silexlabs/CloudExplorer2#84

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants