You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
right now all our changes depend on ChangeContext, it would be great if that was instead an interface which would facilitate easy mocking for testing changes. This would be a breaking change as FwLite has it's own changes defined.
Most of the changes would be in IChange and related classes/interfaces. This new IChangeContext interface should be defined in the SIL.Harmony.Core project. In order to declare the interface in Core it will have to change what it depends on a bit. Some changes I would suggest:
change the Commit property type to CommitBase because Commit is defined in SIL.Harmony, not in core, but CommitBAse is in core.
the method Adapt may prove difficult, it's only used internally, it may be easiest to move IObjectBase into SIL.Harmony.Core as well, then Adapt can be declared there as well
the implementation should not be moved into Core.
The text was updated successfully, but these errors were encountered:
right now all our changes depend on ChangeContext, it would be great if that was instead an interface which would facilitate easy mocking for testing changes. This would be a breaking change as FwLite has it's own changes defined.
Most of the changes would be in
IChange
and related classes/interfaces. This newIChangeContext
interface should be defined in theSIL.Harmony.Core
project. In order to declare the interface in Core it will have to change what it depends on a bit. Some changes I would suggest:Adapt
may prove difficult, it's only used internally, it may be easiest to moveIObjectBase
into SIL.Harmony.Core as well, then Adapt can be declared there as wellthe implementation should not be moved into Core.
The text was updated successfully, but these errors were encountered: