From 075cd6302d391b4f7125c72d505fb33a5a5969d0 Mon Sep 17 00:00:00 2001 From: Robin Munn Date: Tue, 19 Nov 2024 08:00:43 +0700 Subject: [PATCH] Also don't throw exception if JSON has wrong prop --- backend/LexBoxApi/Services/HgService.cs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/backend/LexBoxApi/Services/HgService.cs b/backend/LexBoxApi/Services/HgService.cs index 19836bf37..80601914a 100644 --- a/backend/LexBoxApi/Services/HgService.cs +++ b/backend/LexBoxApi/Services/HgService.cs @@ -275,8 +275,8 @@ private string[] GetWsList(System.Xml.XmlElement root, string tagName) try { var json = JsonDocument.Parse(text); - if (json.RootElement.GetProperty("modelversion").TryGetInt32(out int version)) return version; - _logger.LogError("Invalid model version in GetModelVersionOfFlexProject, should be a number but got {modelversion}", json.RootElement.GetProperty("modelversion").ToString()); + if (json.RootElement.TryGetProperty("modelversion", out var modelversion) && modelversion.TryGetInt32(out int version)) return version; + _logger.LogError("Invalid JSON {text} in GetModelVersionOfFlexProject, should have one property \"modelversion\" that's a number", text); return null; } catch (JsonException e)