From 20a2fd163e3f47356798d87639fa868335d8615d Mon Sep 17 00:00:00 2001 From: Robin Munn Date: Tue, 7 Jan 2025 17:50:08 -0500 Subject: [PATCH] Better use of Task.WhenAll --- backend/LfClassicData/LfClassicMiniLcmApi.cs | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/backend/LfClassicData/LfClassicMiniLcmApi.cs b/backend/LfClassicData/LfClassicMiniLcmApi.cs index 3a8f5c0add..a69baf6cbd 100644 --- a/backend/LfClassicData/LfClassicMiniLcmApi.cs +++ b/backend/LfClassicData/LfClassicMiniLcmApi.cs @@ -239,7 +239,7 @@ private async IAsyncEnumerable Query(QueryOptions? options = null, string private async Task ToEntry(Entities.Entry entry) { - List senses; + Sense[] senses; if (entry.Senses is null) { senses = []; @@ -247,8 +247,7 @@ private async Task ToEntry(Entities.Entry entry) else { var senseTasks = entry.Senses.OfType().Select(sense => ToSense(entry.Guid, sense)); - await Task.WhenAll(senseTasks); - senses = senseTasks.Select(task => task.Result).ToList(); + senses = await Task.WhenAll(senseTasks); } return new Entry { @@ -257,7 +256,7 @@ private async Task ToEntry(Entities.Entry entry) LexemeForm = ToMultiString(entry.Lexeme), Note = ToMultiString(entry.Note), LiteralMeaning = ToMultiString(entry.LiteralMeaning), - Senses = senses, + Senses = new List(senses), }; }