From 2b38c07160c3bbd8a8560173bc8e21cd5ce1212c Mon Sep 17 00:00:00 2001
From: Tim Haasdyk <tim_haasdyk@sil.org>
Date: Tue, 22 Oct 2024 10:19:16 +0200
Subject: [PATCH] Fix viewer build warnings

---
 .../lib/entry-editor/object-editors/EntityEditor.svelte  | 3 ---
 .../lib/entry-editor/object-editors/EntryEditor.svelte   | 1 -
 .../lib/entry-editor/object-editors/ExampleEditor.svelte | 1 -
 .../lib/entry-editor/object-editors/SenseEditor.svelte   | 1 -
 frontend/viewer/svelte.config.js                         | 9 ++++++---
 frontend/viewer/vite.config.ts                           | 7 ++-----
 6 files changed, 8 insertions(+), 14 deletions(-)

diff --git a/frontend/viewer/src/lib/entry-editor/object-editors/EntityEditor.svelte b/frontend/viewer/src/lib/entry-editor/object-editors/EntityEditor.svelte
index 5fa0fb049..5689cf841 100644
--- a/frontend/viewer/src/lib/entry-editor/object-editors/EntityEditor.svelte
+++ b/frontend/viewer/src/lib/entry-editor/object-editors/EntityEditor.svelte
@@ -2,9 +2,6 @@
   import type { CustomFieldConfig } from '../../config-types';
   import FieldEditor from '../field-editors/FieldEditor.svelte';
 
-  type T = $$Generic<unknown>;
-  // eslint-disable-next-line svelte/valid-compile
-  export let entity: T;
   export let readonly: boolean;
   export let customFieldConfigs: CustomFieldConfig[];
 </script>
diff --git a/frontend/viewer/src/lib/entry-editor/object-editors/EntryEditor.svelte b/frontend/viewer/src/lib/entry-editor/object-editors/EntryEditor.svelte
index 27f8c9833..64ac9b319 100644
--- a/frontend/viewer/src/lib/entry-editor/object-editors/EntryEditor.svelte
+++ b/frontend/viewer/src/lib/entry-editor/object-editors/EntryEditor.svelte
@@ -149,7 +149,6 @@
                       id="note"
                       wsType="analysis"/>
     <EntityEditor
-      entity={entry}
       {readonly}
       customFieldConfigs={[]}
       on:change={() => dispatch('change', {entry})}
diff --git a/frontend/viewer/src/lib/entry-editor/object-editors/ExampleEditor.svelte b/frontend/viewer/src/lib/entry-editor/object-editors/ExampleEditor.svelte
index 77eb015d9..d9215e7be 100644
--- a/frontend/viewer/src/lib/entry-editor/object-editors/ExampleEditor.svelte
+++ b/frontend/viewer/src/lib/entry-editor/object-editors/ExampleEditor.svelte
@@ -26,7 +26,6 @@
                      id="reference"
                      wsType="first-analysis"/>
   <EntityEditor
-    entity={example}
     {readonly}
     customFieldConfigs={[]}
     on:change
diff --git a/frontend/viewer/src/lib/entry-editor/object-editors/SenseEditor.svelte b/frontend/viewer/src/lib/entry-editor/object-editors/SenseEditor.svelte
index c0dd94f63..2b3e94593 100644
--- a/frontend/viewer/src/lib/entry-editor/object-editors/SenseEditor.svelte
+++ b/frontend/viewer/src/lib/entry-editor/object-editors/SenseEditor.svelte
@@ -47,7 +47,6 @@
                     id="semanticDomains"
                     wsType="first-analysis" />
   <EntityEditor
-    entity={sense}
     {readonly}
     customFieldConfigs={[]}
     on:change
diff --git a/frontend/viewer/svelte.config.js b/frontend/viewer/svelte.config.js
index b3c7d1131..733b37377 100644
--- a/frontend/viewer/svelte.config.js
+++ b/frontend/viewer/svelte.config.js
@@ -1,12 +1,15 @@
-import { fileURLToPath } from 'url';
+import {fileURLToPath} from 'url';
 import path from 'path';
-import { sveltePreprocess } from 'svelte-preprocess';
-import { vitePreprocess } from '@sveltejs/vite-plugin-svelte'
+import {sveltePreprocess} from 'svelte-preprocess';
+import {vitePreprocess} from '@sveltejs/vite-plugin-svelte';
 
 const __dirname = path.dirname(fileURLToPath(import.meta.url));
 const postcssConfig = path.join(__dirname, 'postcss.config.cjs');
 
 export default {
+  compilerOptions: {
+    customElement: true,
+  },
   // Consult https://svelte.dev/docs#compile-time-svelte-preprocess
   // for more information about preprocessors
   preprocess: [vitePreprocess(), sveltePreprocess({
diff --git a/frontend/viewer/vite.config.ts b/frontend/viewer/vite.config.ts
index c8aa1952d..fe280fd2c 100644
--- a/frontend/viewer/vite.config.ts
+++ b/frontend/viewer/vite.config.ts
@@ -1,5 +1,5 @@
-import { defineConfig } from 'vite'
-import { svelte } from '@sveltejs/vite-plugin-svelte'
+import {defineConfig} from 'vite';
+import {svelte} from '@sveltejs/vite-plugin-svelte';
 
 // https://vitejs.dev/config/
 export default defineConfig(({ mode }) => {
@@ -28,9 +28,6 @@ export default defineConfig(({ mode }) => {
       },
     },
     plugins: [svelte({
-      compilerOptions: {
-        customElement: true,
-      },
       onwarn: (warning, handler) => {
         // we don't have control over these warnings and there are lots
         if (warning.filename?.includes('node_modules/svelte-ux')) return;