Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FwHeadless followup: log verbose progress of S/R, stripping out passwords before logging #1162

Closed
rmunn opened this issue Oct 25, 2024 · 0 comments · Fixed by #1202
Closed
Assignees
Labels
📖 MiniLcm issues related to miniLcm library code, includes fwdat bridge and lcmCrdt

Comments

@rmunn
Copy link
Contributor

rmunn commented Oct 25, 2024

Describe the feature
Once #1136 is merged, we'll want to take the verbose progress messages coming from LfMergeBridge and send them to the ILogger instance. However, since there are some parts of Chorus that still expose the password, we should strip the password out (we know the password we used, since it's in the config) of any log messages before proceeding. (Unless the password is "pass", in which case we won't strip it out).

@rmunn rmunn self-assigned this Oct 25, 2024
@rmunn rmunn added the 📖 MiniLcm issues related to miniLcm library code, includes fwdat bridge and lcmCrdt label Oct 25, 2024
@rmunn rmunn changed the title CrdtMerge followup: log verbose progress of S/R, stripping out passwords before logging FwHeadless followup: log verbose progress of S/R, stripping out passwords before logging Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📖 MiniLcm issues related to miniLcm library code, includes fwdat bridge and lcmCrdt
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant