Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

activity changes text is editable #1329

Closed
hahn-kev opened this issue Dec 20, 2024 · 5 comments · Fixed by #1370
Closed

activity changes text is editable #1329

hahn-kev opened this issue Dec 20, 2024 · 5 comments · Fixed by #1370
Assignees
Labels
bug Something isn't working 💻 FW Lite issues related to the fw lite application, not miniLcm or crdt related Good first issue not too difficult, limited scope

Comments

@hahn-kev
Copy link
Collaborator

Describe the bug
the input box on the activity dialog where the changes are shown is editable, it should be readonly.

Expected behavior
Text box should not be editable, however the text should still be selectable, I think if you use the readonly attribute then you can't interact with the text anymore, this is not desired.

@hahn-kev hahn-kev added bug Something isn't working 💻 FW Lite issues related to the fw lite application, not miniLcm or crdt related labels Dec 20, 2024
@hahn-kev hahn-kev added the Good first issue not too difficult, limited scope label Jan 8, 2025
@rmunn
Copy link
Contributor

rmunn commented Jan 10, 2025

My testing on Firefox showed that setting readonly on the text fields still allowed me to select the text and copy it to paste elsewhere, but I couldn't edit it anymore. So the readonly attribute might be what we need.

P.S. That was testing the input fields in the "View History" button on each entry.

@rmunn
Copy link
Contributor

rmunn commented Jan 10, 2025

... Well, we can set a "readonly" attribute on the TextField component from svelte-ux, but it doesn't actually list readonly as a prop, and doesn't pass that attribute on to the actual HTML element. So this, like #1328, won't be quite as trivial to solve as I would have liked.

@rmunn rmunn self-assigned this Jan 10, 2025
@rmunn
Copy link
Contributor

rmunn commented Jan 10, 2025

svelte-ux exposes an inputEl prop so you can bind:inputEl and get the HTML element to manipulate if to need to, but https://www.github.com/techniq/svelte-ux/issues/357 is preventing us from getting it on a textfield (i.e., the Activity view). So this might actually be blocked on that upstream issue.

@hahn-kev
Copy link
Collaborator Author

@rmunn see #1370, I solved this the same way that CrdtTextField did, that is disabling the input and using some CSS to make it not look disabled

@hahn-kev
Copy link
Collaborator Author

I also opened techniq/svelte-ux#531 to fix the issue of not being able to get the multitext element in svelte-ux

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working 💻 FW Lite issues related to the fw lite application, not miniLcm or crdt related Good first issue not too difficult, limited scope
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants