Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Batch pretranslate on previously built Nmt Engine #230

Closed
johnml1135 opened this issue Dec 2, 2023 · 2 comments
Closed

Batch pretranslate on previously built Nmt Engine #230

johnml1135 opened this issue Dec 2, 2023 · 2 comments
Assignees
Labels
enhancement New feature or request requirement

Comments

@johnml1135
Copy link
Collaborator

johnml1135 commented Dec 2, 2023

This would involve a few parts to implement seamlessly, but in general I would imagine this user scenario:

  • The user built an engine and is drafting
  • Low and behold, they want a different book drafted than they originally thought they wanted! They request a "fast draft" of that book.
  • 5 minutes later, they have the book drafted!

The API workflow could look like this:

  • The Nmt engine is marked for persistence.
  • The user requests another build and either:
    • Has the same exact training corpora? Has no training corpora?
    • Has a special flag in the options?
  • it would also be helpful to have queue name so that we can assign it to a fast turn GPU to get a nice 5-20 minute turn, rather than 10 hours - New NMT option - choose ClearML queue #465
@johnml1135 johnml1135 added this to Serval Dec 2, 2023
@github-project-automation github-project-automation bot moved this to 🆕 New in Serval Dec 2, 2023
@johnml1135 johnml1135 changed the title Inference off of previously built Nmt Engine - batch mode Batch pretranslate on previously built Nmt Engine Dec 2, 2023
@johnml1135 johnml1135 added this to the Serval API 1.2 milestone Dec 2, 2023
@johnml1135 johnml1135 moved this from 🆕 New to 🔖 Ready in Serval Dec 2, 2023
@johnml1135 johnml1135 removed this from the Serval API 1.2 milestone Jan 3, 2024
@johnml1135 johnml1135 added enhancement New feature or request requirement labels Jan 3, 2024
@johnml1135
Copy link
Collaborator Author

Two potential ways to invoke:

  • If everything is the same (same corpora, same revisions of files, same build params)
  • If explicitly invoked

@johnml1135
Copy link
Collaborator Author

Duplicate of #350.

@github-project-automation github-project-automation bot moved this from 🔖 Ready to ✅ Done in Serval Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request requirement
Projects
Status: ✅ Done
Development

No branches or pull requests

2 participants