-
-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
entry number for display and navigation #1013
Comments
Another related idea is knowing how many entries are in the filtered list vs how many total entries there are. If there's a filter active, the "Next" and "Previous" buttons should go to the next or previous entry in the filtered list, not in the total list. So if the filter is Might also want to have a second entry number when there's a filtered list. E.g., housewarming is entry 1,004 and is also "number 5 out of 27 entries that match current filter". (However we'd phrase that in the UI). |
And another related idea would be to track some sort of "doneness" alongside unreadness, possibly with a flag the user can set, and display how many entries are done vs how many are marked as being in need of work. For example, the project manager might want to tag a certain number of entries as being in need of revision with the language team. Then when the language team meets, they could filter the entire list by "Entry status: Needs Work". As they move through each entry, they could click on a button or checkbox for "this is done", and that entry would be auto-flagged as "Entry status: Completed" and they would move on to the next one, with a progress marker saying "37 out of 120 entries completed". Finally, when they finished all 120 out of 120 entries, there could be a bulk-edit feature that would remove the Completed status from all of them and send their status back to "empty", because that way next time the user marks off 10 entries to be worked on, they would see "0/10 complete" instead of "120/130 complete". |
This is how WordReference gives users quick access to their recently viewed entries on mobile. It does require a few taps, but I feel like it's a good tradeoff, given how often the feature will be used (probably less often on mobile). Screen_Recording_20210902-092243_WordReference.mp4 |
After a conversation with @alex-larkin he doesn't see the need for this feature because he and others like him are not using Language Forge in a linear way to do a dictionary cleanup tasks. Some people like Margarete are doing dictionary cleanup and need a way to navigate to a specific place in the list. I'm tabling this feature for now, however I think it will be important to implement at some point. It could perhaps be implemented under a "navigate" sub-menu. |
fwiw, the scrollbar starting at the top rather than mapping to the "current" word might be a quick |
Ah okay, are you just saying we should pull that out into a different issue? |
potentially, just offering that as a possibility but it's something we could discuss at our next stand-up. |
Ok. I also just created #1129 to separate out the "recently viewed entries list" idea into it's own issue. |
I went and added it to the Backlog as well. |
Just had an emphatic request for this feature from a user who would greatly benefit from it. I'm going to put it on the September project board and we can prioritize it at our next meeting. |
During standup today, we discussed how the code loads the entries into IndexedDB as they come from the server, so that they're available offline. The function that does this is It's a lot of code to read through, but once you're done reading through all that code, you'll come away with a better understanding of the data flow. |
Hi @palmtreefrb , as @rmunn said, you'll want to take a look at the EditorDataService, specifically the two arrays
Additionally, there is a method getIndexInList() that will figure out what the index is given an entry id. I hope this helps you get farther on this card - thanks for your hard work! |
Just tested in QA and it looks good, |
Tested on QA and it looks good to me as well. |
The current controls for navigating the list make it difficult to know exactly how far down a word is the dictionary list.
The list scrollbar does not accurately depict how far down one is in the dictionary (progress) and continues to jump as you scroll down to the bottom, because it is loading more items into the list.
There are previous/next buttons for navigation, but it's not clear what entry number you are on when you navigate back and forth through entries.
In summary, this issue describes a new feature to display the entry number which also acts as a "go to" entry input. The proposal is to add an input in-between the prev/next buttons and display the current entry number. The user may also type in a number, which when navigating away or pressing enter, that number of entry is displayed.
Mockup:
![image](https://user-images.githubusercontent.com/3444521/126747234-0a77c649-7786-4db3-970f-1cce77f3d5b5.png)
Requirements:
The text was updated successfully, but these errors were encountered: