Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: Button bar too tall on mobile #1290

Closed
2 tasks
alex-larkin opened this issue Jan 21, 2022 · 2 comments · Fixed by #1367
Closed
2 tasks

bug: Button bar too tall on mobile #1290

alex-larkin opened this issue Jan 21, 2022 · 2 comments · Fixed by #1367
Assignees
Labels
bug An existing problem with our app in production user observed Issue reported by a user with our app in production

Comments

@alex-larkin
Copy link

alex-larkin commented Jan 21, 2022

Proposed Solution

Given @alex-larkin 's bug report below, I (Chris) am recommending the following solution. On mobile, we should hide the entry number display and prev/next buttons on the mobile view. This can be done using the CSS display: none method for a particular breakpoint as seen here.

The solution is implemented when:

  • The entry number display and prev/next buttons are hidden in mobile view
  • The entry number display and prev/next buttons are visible in desktop/tablet view

Describe the bug

The new entry number is a very handy feature, but presently it causes the top button bar (encased in the gray box) to double in height on mobile, costing the user precious vertical space.

Screenshot_20220121-141242_Chrome

Related: Pull request #1215

To Reproduce
Load an entry on mobile

Expected behavior
The top blue bar should only have one row of buttons, maximizing use of screen space.

Mobile (please complete the following information):

  • Device: Samsung Galaxy S10e
  • OS: Android 10
  • Browser: Chrome

Android App in Google Play
For Mobile, are you using the Language Forge Android app in the Google Play store? No

Possible solutions

  1. Make the text box narrower on mobile
  2. Make the button bar scrollable on mobile.
  3. Remove the comment button or history button on mobile
  4. Move the comment button or history button on mobile to somewhere else
  5. Create a floating button that lives in the corner of the screen which, when pressed, expands to show the comment button, history button, and possibly other functions such as Settings, Share, and the avatar options (My profile, Change Password, Logout). We could also consider moving other buttons there, such as the help options and interface language options.

I think option 2 would be a good quick fix, while option 5 would be the most ideal solution, but also the one requiring the most coding.

What are your thoughts?

@alex-larkin alex-larkin added triage bug An existing problem with our app in production labels Jan 21, 2022
@megahirt
Copy link
Collaborator

megahirt commented Jan 22, 2022 via email

@megahirt megahirt added user observed Issue reported by a user with our app in production and removed needs triage labels Mar 10, 2022
@palmtreefrb palmtreefrb moved this from To Do to In Progress in Language Forge Classic Mar 17, 2022
@alex-larkin
Copy link
Author

test comment.

@palmtreefrb palmtreefrb moved this from In Progress to Awaiting Review in Language Forge Classic Apr 5, 2022
Repository owner moved this from Awaiting Review to Awaiting Testing (QA) in Language Forge Classic Apr 5, 2022
@megahirt megahirt moved this from Awaiting Testing (QA) to Awaiting Deployment in Language Forge Classic Apr 5, 2022
@megahirt megahirt moved this from Awaiting Deployment to Done in Language Forge Classic Apr 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An existing problem with our app in production user observed Issue reported by a user with our app in production
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants