Correctly extract hashtag content in links and Page Picker filter #1199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zefhemel
requested changes
Jan 4, 2025
|
Looks good, but indeed let's use the @silverbulletmd/silverbullet style imports where possible |
Maarrk
force-pushed
the
pr-rendered-hashtag
branch
from
b344f02 to
fe67370
Compare
|
Changed to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #1196
Also went through the code and looked at all instances of
replace("#,replace('#, andslice(1to find other locations whereextractHashtagshould be used. I think now it should be good.Also, is there a preference between imports starting with
../../plug-apiand@silverbulletmd/silverbullet? I see both throughout the codebase, and seems to me that Deno uses one or the other for automatic imports. I'd say that the second option is easier to copy into other files.