Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new labels and standardise labels across all repos #154

Closed
3 of 4 tasks
GuySartorelli opened this issue Nov 1, 2023 · 2 comments
Closed
3 of 4 tasks

Add new labels and standardise labels across all repos #154

GuySartorelli opened this issue Nov 1, 2023 · 2 comments
Assignees

Comments

@GuySartorelli
Copy link
Member

GuySartorelli commented Nov 1, 2023

We currently don't have a "type" label for various cards, such as spikes or administrative tasks. We should implement a "type/other" label for this purpose.

We should also add a "affects/v6" label in preparation for working on Silverstripe CMS 6.

Documentation for labels is at https://docs.silverstripe.org/en/contributing/issues_and_bugs/#labels

NOTES

  • The "affects" labels are for things that actually do affect that version. i.e. there is no v6 yet, so there should be nothing using the "affects/v6" label yet.
    • To mark cards as needing to be implemented in a new major release, the "type/api-break" label should be used.
    • This is because if we added "affects/v6" to a bunch of cards and then don't implement changes for those cards, we end up with outdated labels on those cards.
    • The definition already states "Issue has been observed on a specific CMS release line" so that might be sufficient

Acceptance criteria

  • A new "type/other" label is added and documented (document in cms 4 and 5 docs)
  • A new "affects/v6" label is added
  • The labels documentation is updated to more clearly indicate the purpose of the "affects" labels.
  • A script is added to the module standardiser to standardise labels, and that script is run across all repositories we care about

Note

  • We will create the affects/v6 label once we start actively working on CMS6.

PR

@GuySartorelli
Copy link
Member Author

Capability added - reassigning to steve to roll out across repos

@GuySartorelli GuySartorelli removed their assignment Jan 29, 2024
@GuySartorelli
Copy link
Member Author

PRs merged, all steps completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants