Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove supported badges from unsupported repos #197

Closed
3 tasks
emteknetnz opened this issue Feb 15, 2024 · 2 comments
Closed
3 tasks

Remove supported badges from unsupported repos #197

emteknetnz opened this issue Feb 15, 2024 · 2 comments
Assignees

Comments

@emteknetnz
Copy link
Member

emteknetnz commented Feb 15, 2024

Because module standardiser will only update supported repos, it fail to remove supported badges from the README.md of unsupported repos because it won't run script on it

Ckan registry still has a supported badge on it despite it not being supported for cms 5, though it is supported for cms 4

To decide

First we need to clarify that we indeed should not display the supported badge on things that are only supported for cms 4. If we do still want a badge then it should be a different badge IMO that says supported for security only

Acceptance criteria

  • Update module-standardiser to remove the supported badge from unsupported modules.
  • Only the CMS 5 branches should be updated.
  • All modules that lost their supported status in CMS 5 should loose their badge.

PRs

@maxime-rainville
Copy link
Contributor

I'm happy to remove badges once support is dropped by the latest major.

I guess if we want to be especially formal about this, we could remove the badge from the default branch, but keep it on the branches where the module was supported.

@GuySartorelli
Copy link
Member

PRs merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants